[U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

Marek Vasut marex at denx.de
Mon Jun 16 04:03:13 CEST 2014


On Monday, June 16, 2014 at 03:39:08 AM, Otavio Salvador wrote:
> On Sun, Jun 15, 2014 at 10:27 PM, Marek Vasut <marex at denx.de> wrote:
> > On Monday, June 16, 2014 at 03:22:22 AM, Otavio Salvador wrote:
> > 
> > [...]
> > 
> >> >> +#ifdef CONFIG_SYS_FSL_ESDHC_FORCE_VSELECT
> >> >> +     esdhc_setbits32(&regs->vendorspec, ESDHC_VENDORSPEC_VSELECT);
> >> >> +#endif
> >> > 
> >> > Documentation is missing.
> >> 
> >> There is no FSL ESDHC README file so that's why I didn't include it
> >> anywhere.
> > 
> > I'm at loss for words here, really...
> > 
> > I think you know what needs to be done (hint: write the documentation),
> > right ?
> 
> I won't write the full documentation for it. I am sorry.

Undocumented configuration option is not acceptable, period.

Best regards,
Marek Vasut


More information about the U-Boot mailing list