[U-Boot] [PATCH 5/6] Print ramdisk load address if it is in use

[Otavio Salvador]

On Mon, Jun 16, 2014 at 1:38 AM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Otavio Salvador,
>
> In message <1402879613-21362-5-git-send-email-otavio at ossystems.com.br> you wrote:
>> When debugging initramfs failures it is quite useful to known where it
>> is being loaded from.
>
> Agreed.
>
>> +
>> +             printf("   ramdisk load start = 0x%08lx, ramdisk load end = 0x%08lx\n",
>> +                        *initrd_start, *initrd_end);
>>       } else {
>>               *initrd_start = 0;
>>               *initrd_end = 0;
>>       }
>> -     debug("   ramdisk load start = 0x%08lx, ramdisk load end = 0x%08lx\n",
>> -                     *initrd_start, *initrd_end);
>
> As you write yourself, this is a debug feature.  There is no need to
> pollute normal output with such information.  It just makes booting
> slower.  So debug() is appropriate here.
>
> And I don't see why you would NOT want to have the information in
> the else case.
>
> I don't think this change is a good idea.  It should not be applied.

Ok, no problem with me.

I will drop it for v2.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750