[U-Boot] [PATCH 4/6] mmc: fsl_esdhc: Add support to force VSELECT set

[Igor Grinberg]

Hi Otavio,

On 06/16/14 14:48, Otavio Salvador wrote:
> On Mon, Jun 16, 2014 at 4:03 AM, Igor Grinberg <grinberg at compulab.co.il> wrote:
>> Hi Otavio,
>>
>> On 06/16/14 05:24, Otavio Salvador wrote:
>>> On Sun, Jun 15, 2014 at 11:03 PM, Marek Vasut <marex at denx.de> wrote:
>>>> On Monday, June 16, 2014 at 03:39:08 AM, Otavio Salvador wrote:
>>>>> On Sun, Jun 15, 2014 at 10:27 PM, Marek Vasut <marex at denx.de> wrote:
>>>>>> On Monday, June 16, 2014 at 03:22:22 AM, Otavio Salvador wrote:
>>>>>>
>>>>>> [...]
>>>>>>
>>>>>>>>> +#ifdef CONFIG_SYS_FSL_ESDHC_FORCE_VSELECT
>>>>>>>>> +     esdhc_setbits32(&regs->vendorspec, ESDHC_VENDORSPEC_VSELECT);
>>>>>>>>> +#endif
>>>>>>>>
>>>>>>>> Documentation is missing.
>>>>>>>
>>>>>>> There is no FSL ESDHC README file so that's why I didn't include it
>>>>>>> anywhere.
>>>>>>
>>>>>> I'm at loss for words here, really...
>>>>>>
>>>>>> I think you know what needs to be done (hint: write the documentation),
>>>>>> right ?
>>>>>
>>>>> I won't write the full documentation for it. I am sorry.
>>>>
>>>> Undocumented configuration option is not acceptable, period.
>>>
>>> Who accepted the driver in the first version, without Doc?
>>>
>>> I am not in the position to write the full doc.
>>
>> I think there is a misunderstanding here...
>> I think Marek does not want to say that you need to write the full
>> documentation for the driver, but only document the CONFIG_SYS_FSL_ESDHC_FORCE_VSELECT configuration option (what does it
>> do when you define it and why should one define it).
> 
> Great but where if it does not exist?
> 
> should I make a README.fsl-esdhc and include just it?

Hmmm... May be.
I would make a decision and start something, then send an RFC.
Writing some words should not be hard especially for configuration
options that you introduce yourself, but if you find some stuff
currently hard or time consuming for some reason, a "TODO: ..."
might be an acceptable compromise.


-- 
Regards,
Igor.