[U-Boot] [Patch v2 0/7] Add support for TQMa6 modules

[Stefano Babic]

Hi Markus,

On 16/06/2014 18:51, Markus Niebel wrote:
> From: Markus Niebel <Markus.Niebel at tq-group.com>
> 
> This series add support for the TQMa6 boards from TQ Systems.
> The first Patch adds basic support for the modiules and the 
> starterkit baseboard while the other patches add additional features
> 
> Markus Niebel (7):
>   Add TQ Systems TQMa6 board support
>   TQMa6: mba6: add RGMII enet
>   TQMa6: add SPI support
>   TQMa6: add SPI NOR boot support
>   TQMa6: MBa6: add usb support
>   TQMa6: add I2C support
>   TQMa6: add pmic support
> 
>  board/tqc/tqma6/Makefile     |    9 +
>  board/tqc/tqma6/README       |   35 ++++
>  board/tqc/tqma6/clocks.cfg   |   24 +++
>  board/tqc/tqma6/tqma6.c      |  258 +++++++++++++++++++++++
>  board/tqc/tqma6/tqma6_bb.h   |   30 +++
>  board/tqc/tqma6/tqma6_mba6.c |  358 +++++++++++++++++++++++++++++++
>  board/tqc/tqma6/tqma6q.cfg   |  125 +++++++++++
>  board/tqc/tqma6/tqma6s.cfg   |  125 +++++++++++
>  boards.cfg                   |    4 +
>  include/configs/tqma6.h      |  477 ++++++++++++++++++++++++++++++++++++++++++

I understand that your patchset follow your internal development.
However, it is very uncommon that patches introducing new files are
followed by patches changing the same files again.

I think you should squash your patches.  This makes easy to review them.

Do you take a look at the last patches to have a single image running on
different variations of i.MX6 ? Dual and Quad are supported. Some work
for the Solo is required.

Is it not an attractive alternative for you ? Instead of having several
entries in boards.cfg for each variation of your board, you could have
maybe only one or a couple.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================