[U-Boot] [[PATCH v2]] video: ipu_disp: squash clang warning

Jeroen Hofstee jeroen at myspectrum.nl
Tue Jun 17 19:20:27 CEST 2014


Since rgb2ycbcr_coeff and friends are declared const, but assigned
to a void pointer, clang will warn that the const is implicity casted
away. If the pointer is changed to void const * gcc will warn when it
is implicitly casted to a const int array. Just add a correctly
typed pointer instead to prevent these casts and hence the warnings.

Cc: Troy Kisky <troy.kisky at boundarydevices.com>
Cc: Stefano Babic <sbabic at denx.de>
Signed-off-by: Jeroen Hofstee <jeroen at myspectrum.nl>

---
changes since v1:
  Do actually fix the warning. As pointed out by Troy Kisky
  the patch was doing something different then the commit
  message said.

  ... and prefix subject with v2
---
 drivers/video/ipu_disp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/ipu_disp.c b/drivers/video/ipu_disp.c
index cefd2dc..d5e857c 100644
--- a/drivers/video/ipu_disp.c
+++ b/drivers/video/ipu_disp.c
@@ -33,7 +33,7 @@ enum csc_type_t {
 
 struct dp_csc_param_t {
 	int mode;
-	void *coeff;
+	const int (*coeff)[5][3];
 };
 
 #define SYNC_WAVE 0
-- 
1.8.3.2



More information about the U-Boot mailing list