[U-Boot] [PATCH v3 5/5] Exynos: Split 5250 and 5420 memory bank configuration

[Minkyu Kang]

Dear Simon Glass,

On 18/06/14 15:47, Simon Glass wrote:
> Hi Minkyu,
> 
> On 17 June 2014 23:30, Minkyu Kang <mk7.kang at samsung.com> wrote:
>> On 18/06/14 11:11, Simon Glass wrote:
>>> Hi Minkyu,
>>>
>>> On 16 June 2014 23:28, Minkyu Kang <mk7.kang at samsung.com> wrote:
>>>> Dear Akshay Saraswat,
>>>>
>>>> On 04/06/14 01:17, Akshay Saraswat wrote:
>>>>> From: Michael Pratt <mpratt at chromium.org>
>>>>>
>>>>> Since snow has a different memory configuration than peach, split the
>>>>> configuration between the 5250 and 5420. Exynos 5420 supports runtime
>>>>> memory configuration detection, and can make the determination between 4
>>>>> and 7 banks at runtime.
>>>>
>>>> I think this patch should be included to your peach-pit patchset.
>>>> And I think, the number of banks and the size of bank seems to board specific feature.
>>>> Can you guarantee if it uses same SoC then have same memory banks?
>>>
>>> I think this is better than what we have there at present. There is a
>>> patch from Chromium that puts this in the device tree, but it is
>>> probably best dealt with when more patches have landed.
>>>
>>
>> I didn't deny this patch.
>> My comment is about present state.
>> If you can not guarantee that have same memory banks
>> then please split this configuration to each board's configs.
> 
> For Pit which can support 2GB or 4GB, U-Boot detects the correct size
> at run-time. So the setting in the config file is the *maximum* memory
> supported by that SOC, which is indeed fixed by the SOC and has
> nothing to do with the board.

I see.
Then looks good to me.

Thanks,
Minkyu Kang.