[U-Boot] [U-Boot, U-boot, 1/2] common: cmd_nand: add nand ecclayout command

Jon Loeliger loeliger at gmail.com
Fri Jun 20 16:10:22 CEST 2014


>>> --- a/common/cmd_nand.c
>>> +++ b/common/cmd_nand.c
>>> @@ -462,6 +462,53 @@ static void adjust_size_for_badblocks(loff_t *size,

>>> +       for (i = 0; i < p->eccbytes; i++) {
>>> +               if (i && !(i % 9))
>>> +                       printf("\n    ");
>>> +
>>> +               printf("%2d ", p->eccpos[i]);
>>> +       }
>>
>> Why 9?
>
>
> It's to print a new line on every 9th character position.
> I'll add a comment.

OK, Scott, breath...  I got this one.  It'll be OK...

Ivan,
I am confident Scott understood that a newline would
be generated every ninth-character.  We all get that.  I think
what Scott was asking was why the value 9 was chosen?
Why not 10?  Or 8?  Or 145?  Was it to fit some arbitrary
line length or screen size?  Would it make more sense to
use something familiar like a base 10 or half of base-16?

Thanks,
jdl


More information about the U-Boot mailing list