[U-Boot] [U-Boot, v2, 06/14] bootm: Split out code from cmd_bootm.c

[Tom Rini]

On Thu, Jun 19, 2014 at 05:27:51PM -0600, Simon Glass wrote:
> Hi Tom,
> 
> On 19 June 2014 09:31, Tom Rini <trini at ti.com> wrote:
> > On Thu, Jun 19, 2014 at 11:23:24AM -0400, Tom Rini wrote:
> >> On Thu, Jun 12, 2014 at 07:24:46AM -0600, Simon Glass wrote:
> >>
> >> > This file has code in three different categories:
> >> > - Command processing
> >> > - OS-specific boot code
> >> > - Locating images and setting up to boot
> >> >
> >> > Only the first category really belongs in a file called cmd_bootm.c.
> >> >
> >> > Leave the command processing code where it is. Split out the OS-specific
> >> > boot code into bootm_os.c. Split out the other code into bootm.c
> >> >
> >> > Header files and extern declarations are tidied but otherwise no code
> >> > changes are made, to make it easier to review.
> >> >
> >> > Signed-off-by: Simon Glass <sjg at chromium.org>
> >>
> >> This, on am335x GP EVM doing UART booting (you can replicate the same on
> >> beaglebone black with no SD card / nothing bootable on eMMC and holing
> >> down the "user" button for the first boot, SYSBOOT pins will be set
> >> until next hard power cycle) causes:
> >> Sending /tmp/u-boot-spl.bin, 646 blocks: Give your local XMODEM receive
> >> command now.
> >> Bytes Sent:  82816   BPS:10461
> >>
> >> Transfer complete
> >> Sending: u-boot.img
> >> Ymodem sectors/kbytes sent: 3433/429kyzModem - CRC mode,
> >> 4(SOH)/438(STX)/0(CAN) packets, 2 retries
> >> Loaded 448676 bytes
> >> No valid FDT found - please append one to U-Boot binary, use
> >> u-boot-dtb.bin or define CONFIG_OF_EMBED. For sandbox, use -d <file.dtb>
> >> initcall sequence 8085d568 failed at call 8083e678
> >> ### ERROR ### Please RESET the board ###
> >
> > ... because I didn't use u-boot-dtb.img which is a functional change,
> > which is why I then sent out and applied this morning a patch to move
> > most of this support on am335x_evm to be under ENABLE_VBOOT.
> 
> Yes I was wondering whether you wanted things that way.
> 
> In this case I think the problem is that you need to download
> 'u-boot-dtb.img' instead. But there may be another problem.

Right.  For today I'm not willing to change the default behavour.  But
I'm thinking the next time we add a new platform we think harder about
this (since one problem that needs thinking and fixing, or maybe just
louder documentation, is supporting N different platforms in a binary,
or at least a build, easily).

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140620/42b98d87/attachment.pgp>