[U-Boot] [U-Boot, U-boot, 1/2] common: cmd_nand: add nand ecclayout command
Scott Wood
scottwood at freescale.com
Fri Jun 20 18:31:10 CEST 2014
On Fri, 2014-06-20 at 16:29 +0300, Ivan Khoronzhuk wrote:
> On 06/20/2014 04:00 AM, Scott Wood wrote:
> > On Fri, May 16, 2014 at 09:26:36PM +0300, Khoronzhuk, Ivan wrote:
> >> + } else {
> >> + printf("Setting current device"
> >> + " to ecc layout %d FAILED!\n", idx);
> > Don't wrap user-visible strings (checkpatch should have warned you about
> > this).
>
> For user's eyes it's not wrapped.
That's not the point. Wrapping it in the source means the user can't
grep for the string. Checkpatch should have issued a warning about
this. This is an exception to the 80 column rule.
-Scott
More information about the U-Boot
mailing list