[U-Boot] [PATCH] patman: Only apply patches when we know the original HEAD

Masahiro Yamada yamada.m at jp.panasonic.com
Mon Jun 23 08:28:18 CEST 2014


Hi Simon,

On Sun, 22 Jun 2014 22:54:43 -0600
Simon Glass <sjg at chromium.org> wrote:

> Hi,
> 
> On Jun 22, 2014 10:23 PM, "Fabio Estevam" <festevam at gmail.com> wrote:
> >
> > On Mon, Jun 23, 2014 at 12:39 AM, Simon Glass <sjg at chromium.org> wrote:
> >
> > > The whitespace problems are not common but they do happen sometimes -
> > > or at least I have seen it at times. Unless perhaps checkpatch has got
> > > smarter?
> >
> > Couldn't ./scripts/cleanpatch be used to fix the whitespace issues?
> 
> Maybe. If you know how to test this please give it a try.

Does Patman fix the whitespace issues?


I'm getting confused.

To make things clearer, please let me ask you some questions.

[1] What does "whitespace errors" mean here?

   - Trailing whitespaces ?
   - Spaces before TAB indent ?
   - Or what else ?

[2] What do you expect Patman to do when it finds those errors?
  - Just display an error message ?
     or
  - Fix the issues automatically ?

[3] Which features were missing from scripts/checkpatch.pl
    when you wrote Patman first ?



Best Regards
Masahiro Yamada



More information about the U-Boot mailing list