[U-Boot] [PATCH v4] Exynos: SPI: Fix reading data from SPI flash

Minkyu Kang mk7.kang at samsung.com
Mon Jun 23 10:43:28 CEST 2014


On 18/06/14 21:22, Akshay Saraswat wrote:
> SPI recieve and transfer code in exynos_spi driver has a logical bug.
> We read data in a variable which can hold an integer. Then we assign
> this integer 32 bit value to another variable which has data type uchar.
> Latter represents a unit of our recieve buffer. Everytime when we write
> a value to our recieve buffer we step ahead by 4 units when actually we
> wrote to one unit. This results in the loss of 3 bytes out of every 4
> bytes recieved. This patch intends to fix this bug.
> 
> Signed-off-by: Akshay Saraswat <akshay.s at samsung.com>
> Acked-by: Simon Glass <sjg at chromium.org>
> Tested-by: Simon Glass <sjg at chromium.org>
> ---
> Changes since v3:
> 	- Rebased to top of Tree.
> Changes since v2:
> 	- Added "Acked-by" & "Tested-by".
> 	- Changed assignment for *rxp.
> Changes since v1:
> 	- Added check for step.
> 
>  drivers/spi/exynos_spi.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.



More information about the U-Boot mailing list