[U-Boot] [PATCH v2] ARM: tegra: Disable VPR

[Stephen Warren]

On 06/23/2014 01:20 AM, Alexandre Courbot wrote:
> From: Bryan Wu <pengw at nvidia.com>
> 
> On Tegra114 and Tegra124 platforms, certain display-related registers cannot
> be accessed unless the VPR registers are programmed.  For bootloader, we
> probably don't care about VPR, so we disable it (which counts as programming
> it, and allows those display-related registers to be accessed.
> 
> This patch is based on the commit 5f499646c83ba08079f3fdff6591f638a0ce4c0c
> in Chromium OS U-Boot project.

> diff --git a/arch/arm/cpu/tegra-common/vpr.c b/arch/arm/cpu/tegra-common/vpr.c

> +void config_vpr(void)
> +{
> +	struct mc_ctlr *mc = (struct mc_ctlr *)NV_PA_MC_BASE;
> +
> +	/* VPR is only in T114 and T124 */
> +	switch (tegra_get_chip()) {
> +	case CHIPID_TEGRA114:
> +	case CHIPID_TEGRA124:

You can drop the switch() and call to tegra_get_chip() since this is all
done at compile-time now.

Other than that,
Reviewed-by: Stephen Warren <swarren at nvidia.com>