[U-Boot] [PATCH 1/2] usb: host: xhci: make sure to power up PHY

Felipe Balbi balbi at ti.com
Fri Jun 27 17:36:04 CEST 2014


On Fri, Jun 27, 2014 at 10:27:30AM -0500, Dan Murphy wrote:
> Hi
> 
> On 06/23/2014 04:25 PM, Felipe Balbi wrote:
> > some boards won't work if the PHY isn't explicitly
> > powered up.
> >
> > Signed-off-by: Felipe Balbi <balbi at ti.com>
> > ---
> >  drivers/usb/host/xhci-omap.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/host/xhci-omap.c b/drivers/usb/host/xhci-omap.c
> > index e667810..912b2bd 100644
> > --- a/drivers/usb/host/xhci-omap.c
> > +++ b/drivers/usb/host/xhci-omap.c
> > @@ -98,6 +98,7 @@ static int omap_xhci_core_init(struct omap_xhci *omap)
> >  {
> >  	int ret = 0;
> >  
> > +	usb_phy_power(1);
> 
> Should this not be in the omap_usb_phy.c in the omap_enable_phy call below?
> I mean you are enabling the PHY right?

no, I'm powering it up :-) moreover omap_xhci_core_exit() calls
usb_power_power(0), so it's only balancing the calls.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140627/d0d0afbf/attachment.pgp>


More information about the U-Boot mailing list