[U-Boot] [PATCH V2] hush: fix some quoted variable expansion issues

Simon Glass sjg at chromium.org
Sun Mar 2 01:16:21 CET 2014


Hi Stephen,

On 1 March 2014 17:10, Simon Glass <sjg at chromium.org> wrote:

> Hi Stephen,
>
> On 27 February 2014 22:00, Stephen Warren <swarren at wwwdotorg.org> wrote:
>
>> The following shell command fails:
>>
>> if test -z "$x"; then echo "zero"; else echo "non-zero"; fi
>>
>> (assuming $x does not exist, it prints "non-zero" rather than "zero").
>>
>> ... since "$x" expands to nothing, and the argument is completely
>> dropped, causing too few to be passed to -z, causing cmd_test() to
>> error out early.
>>
>
One more thing - with sandbox I get an error with the tests:

/test/command_ut.c:162: do_ut_cmd: Assertion `!strcmp("y", getenv("e" "_"
"y"))' failed.

This is because I'm not running sandbox in-tree. Is it possible to fix this
with some call to os_getcwd() or similar? Or maybe use /tmp?

Regards,
Simon


More information about the U-Boot mailing list