[U-Boot] [PATCH v6] socfpga: Add socfpga preloader signing to mkimage

[Charles Manning]

Hello Wolfgang

Further to my last response

On Friday 28 February 2014 11:43:47 Charles Manning wrote:
> On Friday 28 February 2014 10:57:21 Wolfgang Denk wrote:
> > > +static uint32_t get_le32(const uint8_t *buf)
> > > +{
> > > +	uint32_t retval;
> > > +
> > > +	retval = (((uint32_t) buf[0]) <<  0) |
> > > +		 (((uint32_t) buf[1]) <<  8) |
> > > +		 (((uint32_t) buf[2]) << 16) |
> > > +		 (((uint32_t) buf[3]) << 24);
> > > +	return retval;
> > > +}
> >
> > Why do you not use existing code (like get_unaligned_le16(),
> > get_unaligned_le32()) ?

From what I see these get_aligned_xxx() functions and friends exist in target 
space, not host land.

From my limited understanding of these matters, it is unwise to call
these functions here.

Are you Ok with that explanation? I will be fixing the other issues you raised 
one way or another.

Best regards

Charles