[U-Boot] net: asix: don't pad odd-length TX packets

Tom Rini trini at ti.com
Fri Mar 7 23:27:37 CET 2014


On Thu, Feb 27, 2014 at 01:27:02PM -0700, Stephen Warren wrote:

> From: Stephen Warren <swarren at nvidia.com>
> 
> For Ethernet/USB RX packets, the ASIX HW pads odd-sized packets so that
> they have an even size. Currently, asix_recv() does remove this padding,
> and asic_send() adds equivalent padding in the TX path. However, the HW
> does not appear to need this packing for TX packets in practical testing
> with "ASIX Elec. Corp. AX88x72A 000001" Vendor: 0x0b95 Product 0x7720
> Version 0.1. The Linux kernel does no such padding for the TX path.
> 
> Remove the padding from the TX path:
> 
> * For consistency with the Linux kernel.
> * NVIDIA has a Tegra simulator which validates that the length of USB
>   packets sent to an ASIX device matches the packet length value inside
>   the packet data. Having U-Boot and the kernel do the same thing when
>   creating the TX packets simplifies the simulator's validation.
> 
> Cc: Lucas Stach <dev at lynxeye.de>
> Cc: Marek Vasut <marex at denx.de>
> Cc: Simon Glass <sjg at chromium.org>
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> Acked-by: Simon Glass <sjg at chromium.org>
> Acked-by: Marek Vasut <marex at denx.de>
> Tested-by: Marek Vasut <marex at denx.de>
> Tested-by: Gerhard Sittig <gsi at denx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140307/f49d5567/attachment.pgp>


More information about the U-Boot mailing list