[U-Boot] [PATCH v4 0/6] usb: net: introduce Moschip MCS7830 driver

Gerhard Sittig gsi at denx.de
Sat Mar 8 19:46:12 CET 2014


this series
- adds a new USB ethernet driver for adapters that are based on the
  MCS7730/7830/7832 chips
- enables the driver for those boards which previously had support for
  "all other" USB ethernet adapters
- updates the README.usb documentation file to list all available
  drivers for USB ethernet adapters

development was done on a taskit stamp9g20, tests were done on the
taskit stamp9g20 as well as wandboard both with "Delock 61147" and
"Logilink UA0025C" adapters, transferring a 56MB file several times
with TFTP

there are several checkpatch warnings
- about CamelCase for NetReceive() and USB related structure members,
  which cannot get fixed as the names are in the established API
- about a multiple assignment for the "found" flags in the USB endpoint
  search, which I consider acceptable

Changes in v4:
- remove a duplicate comment in the mcs7830_read_phy() routine
- remove the actually unused mcs7830_read_config() routine

Changes in v3:
- pick up Simon's ACKs for individual patches
- drop the part of the series which moves BIT() to <common.h>
- remove BIT() macro use, declare constant numbers for bit masks
  for improved portability
- re-word the commit message, include a link to the www.asix.com.tw
  product page, and explictly list the supported chips

Changes in v2:
- introduced the "no #ifdef for prototypes" patch
- don't #ifdef function prototypes in header files (the newly introduced
  mcs7830_*() routines in usb_ether.h)
- remove editor navigation pseudo comments (text fold markers)
- reduce the number of timeout declarations (only USB communication and
  ethernet link status remaining)
- declare the ethernet adapter register set layout by means of a struct
  and offsetof() instead of magic register index numbers
- separate the bit mask declarations from the register layout
  declaration, use the common BIT() macro instead of re-inventing its
  implementation
- rename register layout and bit field macros to reduce excessive
  identifier lengths, and to not collide with the global CONFIG_* name
  space
- introduce kernel nano doc comments for data structures, global
  variables, and all routines
- improve handling of the list of supported dongles, remove the unused
  sentinel and iterate by means of ARRAY_SIZE(), fixup whitespace for
  the Sitecom entry
- decorate the mcs7830_read_config() routine with the "__maybe_unused"
  attribute instead of forcing a reference by means of
  "(void)identifier;" just to silence a potential compiler warning
- silent operation of the ethernet link status detection according to
  U-Boot philosophy, which simplifies the .init() callback code path
- factor out common logic of PHY read/write support (the "emit a request
  and wait for completion" part), unbreak the retry logic (correct
  number of iterations)
- use proper errno.h codes, and propagate errors up in the call chain
- adjust the Cc: list
- introduce the patch to alpha-sort USB adapter config options
- introduce the patch to add MCS7830 USB ethernet to several boards
- introduce the patch to add MCS7830 USB ethernet for taskit stamp9g20
- introduce the patch to update README.usb for USB ethernet options

Gerhard Sittig (6):
  usb: net: don't ifdef routine declarations in usb_ether.h
  usb: net: introduce support for Moschip USB ethernet
  tegra: omap: alpha-sort USB ethernet items for Asix and SMSC
  tegra: imx: omap: enable Moschip USB ethernet support for several
    boards
  at91: enable USB ethernet for taskit stamp9g20
  usb: net: update README.usb to list all USB ethernet options

 doc/README.usb                 |   13 +-
 drivers/usb/eth/Makefile       |    1 +
 drivers/usb/eth/mcs7830.c      |  812 ++++++++++++++++++++++++++++++++++++++++
 drivers/usb/eth/usb_ether.c    |    7 +
 include/configs/harmony.h      |    3 +-
 include/configs/m53evk.h       |    1 +
 include/configs/mx53loco.h     |    1 +
 include/configs/nitrogen6x.h   |    1 +
 include/configs/omap3_beagle.h |    3 +-
 include/configs/stamp9g20.h    |    5 +-
 include/usb_ether.h            |   14 +-
 11 files changed, 850 insertions(+), 11 deletions(-)
 create mode 100644 drivers/usb/eth/mcs7830.c

-- 
1.7.10.4



More information about the U-Boot mailing list