[U-Boot] [PATCH V2 1/3] part_efi: move uuid_string() and string_uuid() to lib/uuid.c

[Tom Rini]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/10/2014 01:24 PM, Stephen Warren wrote:
> On 03/05/2014 09:45 AM, Przemyslaw Marczak wrote:
>> Changes:
>> Move functions:
>> - disk/part_efi.c uuid_string() to lib/uuid.c -> uuid_bin_to_str()
>> - disk/part_efi.c string_uuid() to lib/uuid.c -> uuid_str_to_bin()
>>
>> Update files:
>> - include/common.h
>> - disk/part_efi.c
>> - lib/Makefile
> 
> That's not a particularly useful patch description. How about:
> 
> Move uuid<->string conversion functions into lib/uuid.c so they can be
> used by code outside part_efi.c. Rename uuid_string() to
> uuid_bin_to_str(), so that's the naming is consistent with the existing
> uuid_str_to_bin(). Add an error return code to uuid_str_to_bin().
> Convert existing users to the new library functions.
> 
> This one patch,
> Acked-by: Stephen Warren <swarren at nvidia.com>

As I'm applying and testing this locally right now, I'll take that
better wording (and ack), thanks!

>> diff --git a/lib/Makefile b/lib/Makefile
> 
>>  obj-$(CONFIG_BOOTP_PXE) += uuid.o
>> +obj-$(CONFIG_PARTITION_UUIDS) += uuid.o
> 
> Oh, I hope listing uuid.o twice in obj-y won't cause any issue...

Nope, we're good, it gets filtered now.  We should handle this better
once we have Kconfig in, but, one step at a time.

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTHfY/AAoJENk4IS6UOR1W71YP/2tunn6ln8Qu3AG4YvcbSnQz
FXESBryhXX4dzBnopwLRTi09zjfLQsT8a/uRpfPbo3OF7zUanoLCF11/eQK5k+Q9
3OcorHX98rozhC6/eyJfF7rzuznOKdh7IL+q+v715jll8riQAo103WVP8kPnjeoN
KvZjl80ZLqX7qVTj4678wPQPJpjDFXF7uHrChfsEd3+XK31+MZrt58L58+VPARHA
43UghkcXGIP5ybFpi/h1N0b8Pu1AjOHC+WgHeUjdjfFiLL4laVFc3eVrPjsSltXf
7Ooq6tlFL9YtmtFToW/Ek2OeNN547bFxC7eVEMgzamUjFpYCTFh9E8ISTmhcJBK4
dnMNQ6obtVSZDYZD1PkPEpLvj48aKByXm2YIgdOo8Ds/Vza4g59VuCw6gFLPqQUz
sR/+xr79GOTK+17ayTkacL0SS3FKbSWTSEtseLltaGtDOGE7UoWh8ENzmm8GwVdH
rmxuR6ebYlLpINgT6oUvIA2i87vAZgjbaZMGzcC3SzI3ehakid3UfX7XBJ4xLJWj
BNtuBq/k43SGsuC3IYAIl1HbQZiAKrQZhlqy80xp2EXp5MbSvEfaCnTV0sCHRWH4
fYoJ8v1ztHVn6Z8QfUL3mvJwR3BRd3UY/R4TD62/A054qPjisu8foFjpcrA+NrRq
+OI1PLXI/hF5DG5gVsgM
=pbb1
-----END PGP SIGNATURE-----