[U-Boot] [PATCH] lcd: Add support for CONFIG_LCD_NOSTDOUT

[Gerhard Sittig]

On Sat, Mar 08, 2014 at 20:46 +0100, Hannes Petermaier wrote:
> 
> Hi Gerhard,
> 
> On 2014-03-06 20:49, Gerhard Sittig wrote:
> >In general U-Boot tries to get away from the multitude of ifdefs
> >where possible.  I'm afraid adding a new one needs a very good
> >reason to get perceived as welcome.
> By the way i've found a passage within README, which tells to do so
> as id id:
> 
> '* If you modify existing code, make sure that your new code does not
>   add to the memory footprint of the code ;-) Small is beautiful!
> 
>   When adding new features, these should compile conditionally only
>   (using #ifdef), and the resulting code with the new feature
>   disabled must not need more memory than the old code without your
>   modification.
> '
> whats your opinion about this ?

This policy may not apply here.  It's applicable to "larger"
chunks of new code, like complete drivers or complex features.
Not everyone wants support for unused features in their
executables that need to fit in constrained resources.  That's
well understood.

Your case is different.  There is a feature, it's already present
and small and unconditional.  And your change even shortcuts this
small portion.  I guess that adding another compiler switch for
this may not be appropriate.

But let's see what others have to say.  I'm not an expert in
policy.


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de