[U-Boot] [PATCH] arm: exynos: Squash bogus warnings in pinmux

[Lukasz Majewski]

Hi Marek,

> On Wednesday, March 12, 2014 at 08:51:56 AM, Lukasz Majewski wrote:
> > Hi Simon, Marek,
> > 
> > > Hi Marek,
> > > 
> > > On 10 March 2014 13:04, Marek Vasut <marex at denx.de> wrote:
> > > > Squash these warnings in pinmux.c found with GCC 4.8:
> > > > 
> > > > /arch/arm/cpu/armv7/exynos/pinmux.c: In function
> > > > 'exynos_pinmux_config': /arch/arm/cpu/armv7/exynos/pinmux.c:687:28:
> > > > warning: 'count' may be used uninitialized in this function
> > > > [-Wmaybe-uninitialized] for (i = start; i < start + count; i++)
> > > > { ^ /arch/arm/cpu/armv7/exynos/pinmux.c:663:16: note: 'count'
> > > > was declared here int i, start, count;
> > > > 
> > > >                 ^
> > > > 
> > > > /arch/arm/cpu/armv7/exynos/pinmux.c:687:28: warning: 'start'
> > > > may be used uninitialized in this function
> > > > [-Wmaybe-uninitialized] for (i = start; i < start + count; i++)
> > > > { ^ /arch/arm/cpu/armv7/exynos/pinmux.c:663:9: note: 'start' was
> > > > declared here int i, start, count;
> > > > 
> > > >          ^
> > > > 
> > > > /arch/arm/cpu/armv7/exynos/pinmux.c:689:19: warning: 'bank' may
> > > > be used uninitialized in this function [-Wmaybe-uninitialized]
> > > > s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2)); ^
> > > > /arch/arm/cpu/armv7/exynos/pinmux.c:662:24: note: 'bank' was
> > > > declared here struct s5p_gpio_bank *bank;
> > > > 
> > > >                         ^
> > > > 
> > > > /arch/arm/cpu/armv7/exynos/pinmux.c: In function
> > > > 'exynos_pinmux_config': /arch/arm/cpu/armv7/exynos/pinmux.c:687:28:
> > > > warning: 'count' may be used uninitialized in this function
> > > > [-Wmaybe-uninitialized] for (i = start; i < start + count; i++)
> > > > { ^ /arch/arm/cpu/armv7/exynos/pinmux.c:663:16: note: 'count'
> > > > was declared here int i, start, count;
> > > > 
> > > >                 ^
> > > > 
> > > > /arch/arm/cpu/armv7/exynos/pinmux.c:687:28: warning: 'start'
> > > > may be used uninitialized in this function
> > > > [-Wmaybe-uninitialized] for (i = start; i < start + count; i++)
> > > > { ^ /arch/arm/cpu/armv7/exynos/pinmux.c:663:9: note: 'start' was
> > > > declared here int i, start, count;
> > > > 
> > > >          ^
> > > > 
> > > > /arch/arm/cpu/armv7/exynos/pinmux.c:689:19: warning: 'bank' may
> > > > be used uninitialized in this function [-Wmaybe-uninitialized]
> > > > s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2)); ^
> > > > /arch/arm/cpu/armv7/exynos/pinmux.c:662:24: note: 'bank' was
> > > > declared here struct s5p_gpio_bank *bank;
> > > > 
> > > >                         ^
> > > > 
> > > > Note that the warning is bogus, the function can never be called
> > > > with invalid 'peripheral' argument. GCC just cannot analyze
> > > > this.
> > > > 
> > > > Signed-off-by: Marek Vasut <marex at denx.de>
> > > > Cc: Naveen Krishna Chatradhi <ch.naveen at samsung.com>
> > > > Cc: Akshay Saraswat <akshay.s at samsung.com>
> > > > Cc: Rajeshwari S Shinde <rajeshwari.s at samsung.com>
> > > > Cc: Simon Glass <sjg at chromium.org>
> > > > Cc: Minkyu Kang <mk7.kang at samsung.com>
> > > > Cc: Tom Rini <trini at ti.com>
> > > 
> > > Acked-by: Simon Glass <sjg at chromium.org>
> > > 
> > > Thanks Marek, great to get that annoyance fixed.
> > 
> > Fix for this issue has been already posted :-) (one week ago)
> > 
> > http://patchwork.ozlabs.org/patch/327065/
> > 
> > But I don't mind if Marek's patch will be applied directly by Tom
> > before v2014.04 is released :-)
> 
> Aren't you missing the exynos5_mmc_config() in your patch ?

Yes, my work miss it. Lets apply your patch and be happy with "clean"
build results from gcc 4.8 :-).

> Otherwise, I don't mind either way and I'd prefer if your patch
> (which came in earlier) was applied of course (unless you are missing
> the _mmc_config).



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group