[U-Boot] [PATCH v5 0/3] ubs: tegra: two fixes and cleanup

Jim Lin jilin at nvidia.com
Wed Mar 12 14:57:33 CET 2014


On Mon, 2014-03-03 at 02:46 +0800, Stefan Agner wrote:
> Only patch 1 is an actual issue while the second patch is
> something I stumbled upon, and the third is more about
> housekeeping.
> 
> I descieded to ifdef the driver, I think that this is easier to
> read and does not mix register access style. The function
> ehci_get_port_speed however don't get a pointer to the usb_ctlr
> struct and thouse has to work around that. I don't changed the
> register access style there because of this reason.
> 
> The third patch is optional and implements Stephen's suggestion
> to merge the USB headers. I'm not sure wheater Tegra124 would
> also profit from this merge, if yes, I think then its definitely
> worth doing it.
> 
> ---
> Changes since v4:
> - Merged Tegra124 USB header file as well
> 
> Changes since v3:
> - Minor cleanup in USB header file
> 
> Changes since v2:
> - Split into multiple patches
> - Using ifdef to account for differences between Tegra20/Tegra30
> - Merging of the header files
> 
> Changes since v1:
> - Take differences between USBD and other USB ports into account
>   port_sc1
> 
> ---
> Stefan Agner (3):
>   usb: tegra: fix USB2 powerdown for Tegra30 and later
>   usb: tegra: fix PHY configuration
>   usb: tegra: combine header file
> 
>  arch/arm/include/asm/arch-tegra/usb.h    | 223 ++++++++++++++++++++++++-
>  arch/arm/include/asm/arch-tegra114/usb.h | 156 ------------------
>  arch/arm/include/asm/arch-tegra124/usb.h | 268 -------------------------------
>  arch/arm/include/asm/arch-tegra20/usb.h  | 155 ------------------
>  arch/arm/include/asm/arch-tegra30/usb.h  | 168 -------------------
>  board/nvidia/common/board.c              |   1 -
>  drivers/usb/host/ehci-tegra.c            |  28 +++-
>  7 files changed, 245 insertions(+), 754 deletions(-)
>  delete mode 100644 arch/arm/include/asm/arch-tegra114/usb.h
>  delete mode 100644 arch/arm/include/asm/arch-tegra124/usb.h
>  delete mode 100644 arch/arm/include/asm/arch-tegra20/usb.h
>  delete mode 100644 arch/arm/include/asm/arch-tegra30/usb.h
> 
This series
Acked-by: Jim Lin <jilin at nvidia.com>

--nvpublic



More information about the U-Boot mailing list