[U-Boot] [U-Boot PATCH v2 00/12] Add support for keystone2 SoC and K2HK EVM

Tom Rini trini at ti.com
Wed Mar 12 20:35:04 CET 2014


On Wed, Mar 12, 2014 at 03:21:26PM -0400, Murali Karicheri wrote:
> On 2/25/2014 5:10 PM, Rini, Tom wrote:
> >On Thu, Feb 20, 2014 at 12:55:02PM -0500, Murali Karicheri wrote:
> >
> >>This patch series add support for keystone2 SoC and K2HK EVM
> >In general, you ran checkpatch.pl right?  I see some '#define<tab>'
> >cases that need manual fixing up as well.  Further comments and acks
> >coming.
> >
> Tom,
> 
> Just want to check with you what you want me to fix for #define
> <tab>. Generally from
> my Linux experience, I have seen #define used with tab. I looked at
> few header files and
> that have this tab in #define. So where this restriction come from?
> I looked into the
> Documentation/CodingStyle in Linux source tree and can't find any
> rule of not to
> use #define <tab>.

It's a thing here at least that yes, '#define<space>' only, and we do
have a few things that need cleaning up.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140312/329c395f/attachment.pgp>


More information about the U-Boot mailing list