[U-Boot] [PATCH v1 3/9] sunxi: initial sun7i dram setup support

[Tom Rini]

On Fri, Mar 14, 2014 at 10:33:45AM +0000, Ian Campbell wrote:

[snip]
> +static void mctl_ddr3_reset(void)
> +{
> +	struct sunxi_dram_reg *dram =
> +			(struct sunxi_dram_reg *)SUNXI_DRAMC_BASE;
> +
> +	{
> +		clrbits_le32(&dram->mcr, DRAM_MCR_RESET);
> +		udelay(2);
> +		setbits_le32(&dram->mcr, DRAM_MCR_RESET);
> +	}

That seems like an odd construction, why the extra braces?

And as for the rest of the code, lots of magic numbers to #define
what/why (why udelay(2) and 22?)

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140314/87cb5bdc/attachment.pgp>