[U-Boot] [PATCH v1 5/9] sunxi: generic sun7i build infrastructure.

[Tom Rini]

On Fri, Mar 14, 2014 at 10:33:47AM +0000, Ian Campbell wrote:

[snip]
> +#define CONFIG_SUN7I		/* sun7i SoC generation */
[snip]
> +#define CONFIG_ALLWINNER	/* It's a Allwinner chip */
> +#define CONFIG_SUNXI		/* which is sunxi family */

Please make sure we end up using all 3 of these.  I know I spotted a
CONFIG_SUNXI in use, but I don't know about ALLWINNER or SUN7I.

> +/*
> + * Size of malloc() pool
> + * 1MB = 0x100000, 0x100000 = 1024 * 1024
> + */
> +#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (1 << 20))

This is really really small, and precludes using UBI on NAND for
example.

> +#define CONFIG_SYS_PROMPT_HUSH_PS2	"> "

Not needed.

> +/* memtest works on */
> +#define CONFIG_SYS_MEMTEST_START	CONFIG_SYS_SDRAM_BASE
> +#define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_SDRAM_BASE + (256 << 20))

Please see doc/README.memory-test

> +#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, 115200 }

Please use the default table.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140314/254376ab/attachment.pgp>