[U-Boot] [PATCH v4 1/6] part_efi: move uuid<->string conversion functions into lib/uuid.c

Przemyslaw Marczak p.marczak at samsung.com
Thu Mar 20 09:42:06 CET 2014


Hello,

On 03/19/2014 08:19 PM, Wolfgang Denk wrote:
> Dear Przemyslaw Marczak,
>
> In message <1395251911-26540-1-git-send-email-p.marczak at samsung.com> you wrote:
>> Changes:
>> - move uuid<->string conversion functions into lib/uuid.c so they can be
>>    used by code outside part_efi.c.
>> - rename uuid_string() to uuid_bin_to_str() for consistency with existing
>>    uuid_str_to_bin()
>> - add an error return code to uuid_str_to_bin()
>>
>> Update existing code to the new library functions.
>
> Please make sure to run your patches through checkpatch.  Here I get
> this:
>
> WARNING: line over 80 characters
> #331: FILE: lib/uuid.c:41:
> + * GUID is used e.g. in GPT (GUID Partition Table) as a partiions unique numbers.
>
> Please fix.
>
> Best regards,
>
> Wolfgang Denk
>
Sorry for this. I will fix it in next patchset.
Are other changes acceptable?

Thank you,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com


More information about the U-Boot mailing list