[U-Boot] [PATCH v2 5/9] sunxi: generic sun7i build infrastructure.

[Hans de Goede]

Hi,

On 03/22/2014 01:33 PM, Wolfgang Denk wrote:
> Dear Ian,
> 
> In message <1395482650.2234.104.camel at hastur.hellion.org.uk> you wrote:
>>
>>> What does that mean?  I cannot find these names in the SoB lines?
>>
>> I explained the process by which I arrived at these lists in 0/9. It
>> means that they appear as an author for a commit in the history in the
>> u-boot-sunxi.git, but did not supply an S-o-b. However I am adding my
>> own S-o-b under clause (b) of the DCO, which I believe applies here.
> 
> Please read (again) what the Developer's Certificate of Origin means.
> It appears that such code would fall under clause (c):
> 
> 	The contribution was provided directly to me by some other
> 	person who certified (a), (b) or (c) and I have not modified
> 	it.

No as said before the parts for which we don't have a Signed-off-by
for falls under b), since we took it from existing code which has clear
GPLv2+ license headers on each and every file.

b) Reads:

        (b) The contribution is based upon previous work that, to the best
            of my knowledge, is covered under an appropriate open source
            license and I have the right under that license to submit that
            work with modifications, whether created in whole or in part
            by me, under the same open source license (unless I am
            permitted to submit under a different license), as indicated
            in the file; or




> 
> Did for example "j" or "hehopmajieh" provide such certificates to you?
> 
>> It's entirely possible that none of these peoples' contributions still
>> remain in the files being upstreamed, but figuring that out for sure
>> would be a large and manual task. As I explained in 0/9 I prefer to
>> over-credit by mentioning people whose actual contributions no longer
>> remain rather than fail to credit someone whose contribution does
> 
> The Sob is only partially for crediting; the major purpose is to make
> sure we really have the full rights to distribute such code under the
> listed licenses.  To guarantee that, the chain of certificates mustnot
> be interrupted.

Right, and we do since the files we're basing our work on is GPLv2+ licensed,
the purpose of the listing of extra names other then the Signed-off-by:
tags is for solely for attribution.

>> I have email addresses from the commit authorship, which I should indeed
>> have included here, I shall definitely do that for v3. Please let me
>> know whether or not I should also spend hours trawling down the precise
>> pedigree of each line of code.
> 
> The SoB lines need real names plus real, working mail addresses.  The
> Linux "Documentation/SubmittingPatches" filemakes this clear:
> 
> 	using your real name (sorry, no pseudonyms or anonymous contributions.)

Right but these are not Signed-off-by lines. Just as I may thank a tester
in a commit message with just his name because he does not want me to disclose
his email address, we are attributing people here with just there names.

Note in some cases we do have email addresses and Ian has said he will add those
in the next version, but we cannot magically conjure up Signed-off-by's which we
don't have, and section b) says we don't need to since all the original files
have a clear GPLv2+ license header.

Regards,

Hans