[U-Boot] [PATCH v2 2/2] MarSBoard: add new board

[Wolfgang Denk]

Dear Fabio Estevam,

In message <CAOMZO5D2N1Zvo5ogEAM1_EwT-0KKamzGvRfPEekh5zymQkLrhw at mail.gmail.com> you wrote:
>
> Me too. I also think the ifdefs may easily cause confusion.

So you suggest we remove all conditional code and use duplication
everywhere?  You must be joking...

> For example: if someone sends a patch for Riotboard, he/she may break
> Marsboard without knowing.
> 
> Usually the developer has only one board and is not able to test on both boards.

Yes, of course.  If someone touches common code he make breake things
for boards he did not test.  That has always been the case,
everywehre.  But that has never been a reason to duplicate code,
or to accept code duplication.   On contrary, we permanently struggle
to reduce such duplication.

Otherwise we would have to strictly split ARM and PowerPC code, and
all other architectures.  We would need code copies for each SoC.
Actually each board would need his own version of the whole U-Boot
code.  Sorry, but this is just bizarre...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I don't mind criticism. You know me. I've  never  been  one  to  take
offence  at  criticism. No one could say I'm the sort to take offence
at criticism -- Not twice, anyway. Not without blowing bubbles.
                                  - Terry Pratchett, _Witches Abroad_