[U-Boot] [PATCH v4 6/9] i2c, davinci: convert driver to new mutlibus/mutliadapter framework

Heiko Schocher hs at denx.de
Mon Mar 31 07:24:22 CEST 2014


Hello Mruali,

Am 27.03.2014 16:59, schrieb Murali Karicheri:
> From: Vitaly Andrianov<vitalya at ti.com>
>
>      - add davinci driver to new multibus/multiadpater support
>      - adapted all config files, which uses this driver
>
> Signed-off-by: Vitaly Andrianov<vitalya at ti.com>
> Signed-off-by: Murali Karicheri<m-karicheri2 at ti.com>
> ---
>   arch/arm/cpu/arm926ejs/davinci/dm355.c  |    2 +-
>   arch/arm/cpu/arm926ejs/davinci/dm365.c  |    2 +-
>   arch/arm/cpu/arm926ejs/davinci/dm644x.c |    2 +-
>   arch/arm/cpu/arm926ejs/davinci/dm646x.c |    2 +-
>   drivers/i2c/Makefile                    |    2 +-
>   drivers/i2c/davinci_i2c.c               |  401 ++++++++++++++++++-------------
>   drivers/i2c/davinci_i2c.h               |   27 ++-
>   include/configs/cam_enc_4xx.h           |    8 +-
>   include/configs/da830evm.h              |    8 +-
>   include/configs/da850evm.h              |    8 +-
>   include/configs/davinci_dm355evm.h      |    8 +-
>   include/configs/davinci_dm355leopard.h  |    8 +-
>   include/configs/davinci_dm365evm.h      |    8 +-
>   include/configs/davinci_dm6467evm.h     |    8 +-
>   include/configs/davinci_dvevm.h         |    8 +-
>   include/configs/davinci_schmoogie.h     |    8 +-
>   include/configs/davinci_sffsdr.h        |    8 +-
>   include/configs/davinci_sonata.h        |    8 +-
>   include/configs/ea20.h                  |    6 +-
>   include/configs/enbw_cmc.h              |    8 +-
>   20 files changed, 305 insertions(+), 235 deletions(-)

This is your v4 post ... some sort of history, what has changed
would be nice ...

[...]
> diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
> index 36d5e5f..fd1cb11 100644
> --- a/drivers/i2c/Makefile
> +++ b/drivers/i2c/Makefile
> @@ -6,7 +6,7 @@
>   #
>
>   obj-$(CONFIG_BFIN_TWI_I2C) += bfin-twi_i2c.o
> -obj-$(CONFIG_DRIVER_DAVINCI_I2C) += davinci_i2c.o
> +obj-$(CONFIG_SYS_I2C_DAVINCI) += davinci_i2c.o

please keep lists sorted.

>   obj-$(CONFIG_DW_I2C) += designware_i2c.o
>   obj-$(CONFIG_I2C_MVTWSI) += mvtwsi.o
>   obj-$(CONFIG_I2C_MV) += mv_i2c.o
[...]

Rest looks Ok for me ... if checkpatch drops no errors and warnings
and MAKEALL compiles clean ;-)

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list