[U-Boot] [PATCH v4 1/2] RiOTboard: add new board

Eric Bénard eric at eukrea.com
Mon Mar 31 22:02:34 CEST 2014


Hi Stefano,

Le Sun, 30 Mar 2014 18:20:49 +0200,
Stefano Babic <sbabic at denx.de> a écrit :
> A general remark. I agree by reading the whole thread about checking at
> runtime which is the running board (you do it getting the cpu type).
> 
> However, you use also a compiler switch mechanism, adding RIOTBOARD or
> MARSBOARD in the boards.cfg. You have implemented two ways to for the
> same thing. This makes in principle your runtime detection useless,
> because you can use #if CONFIG_MARSBOARD instead of "if board_type ==
> BOARD_IS_MARSBOARD)". Is it possible to use only the runtime detection ?
> I think the main problem is CONFIG_ENV_IS_*, that is different for the
> two boards. What do you think about it ?
> 
I've tried and I don't see how to include functions to handle both MMC
and SF environment in the same binary with the current env code.

A workaround would be to use MMC to store env also on the MarSBoard but
as it is using the SPI flash as the boot source I would prefer to keep
the env in the SPI flash.

Best regards,
Eric


More information about the U-Boot mailing list