[U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images

Otavio Salvador otavio at ossystems.com.br
Mon Sep 1 03:09:39 CEST 2014


Hello Nitin,

On Sun, Aug 31, 2014 at 5:16 PM,  <nitin.garg at freescale.com> wrote:
> From: Nitin Garg <nitin.garg at freescale.com>
>
> Add hab_auth_img u-boot command which can be used for HAB authentication
> of images.
>
> Signed-off-by: Nitin Garg <nitin.garg at freescale.com>

As the other patch I commented, this commit log also needs some rework
to comply to the guidelines. I would also welcome a more detailed
description about what this adds on top of previous HAB code.

...
> diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h b/arch/arm/include/asm/arch-mx6/sys_proto.h
> index 306d699..2bbb86e 100644
> --- a/arch/arm/include/asm/arch-mx6/sys_proto.h
> +++ b/arch/arm/include/asm/arch-mx6/sys_proto.h
...
> @@ -11,7 +13,7 @@
>  #include <asm/imx-common/regs-common.h>
>  #include "../arch-imx/cpu.h"
>
> -#define soc_rev() (get_cpu_rev() & 0xFF)
> +#define soc_rev() ((int)(get_cpu_rev() & 0xFF))

This seems unrelated change, isn't it?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


More information about the U-Boot mailing list