[U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images

[Otavio Salvador]

On Tue, Sep 2, 2014 at 10:55 PM, Nitin Garg <nitin.garg at freescale.com> wrote:
> On 09/02/2014 08:52 PM, Fabio Estevam wrote:
>> On Tue, Sep 2, 2014 at 10:47 PM, Nitin Garg <nitin.garg at freescale.com> wrote:
>>
>>> But get_cpu_rev is correct, it returns unsigned int.
>>> The problem happens in hab code where there are
>>> comparisons between int and unsigned int, hence
>>
>> Where exactly in the hab code does the problem happen?
>>
> In the macros of HAB, like:
> hab_rvt_report_event_p
>
> The compiler generates bhi instead of bgt.

However looking at the code I didn't see any negative CHIP_REV:

#define CHIP_REV_1_0                 0x10
#define CHIP_REV_1_2                 0x12
#define CHIP_REV_1_5                 0x15

So I am not sure we have a failure case in the U-Boot code now.

I think I am missing something though ...

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750