[U-Boot] [PATCH v3 3/4] cleanup code which handles the Android sparse image format

[Wolfgang Denk]

Dear Steve Rae,

In message <1409763954-5494-4-git-send-email-srae at broadcom.com> you wrote:
> - port dprintf() to debug()
> - update formatting
> 
> Signed-off-by: Steve Rae <srae at broadcom.com>
> ---
> 
> Changes in v3:
> - use original license text
> 
> Changes in v2:
> - use BSD-3-Clause
> 
>  common/aboot.c | 97 +++++++++++++++++++++++++++++++++-------------------------
>  1 file changed, 56 insertions(+), 41 deletions(-)
> 
> diff --git a/common/aboot.c b/common/aboot.c
> index a302c92..3611feb 100644
> --- a/common/aboot.c
> +++ b/common/aboot.c
> @@ -28,6 +28,9 @@
>   * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
>   * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>   *
> + * NOTE:
> + *   Although it is very similar, this license text is not identical
> + *   to the "BSD-3-Clause", therefore, DO NOT MODIFY THIS LICENSE TEXT!
>   */

I understand your intention of starting with the pristine file, and
then adaptng it to U-Boot, but I don't like adding a broken file in
patch 1/4 only to fix it later in patch 3/4. I think it would be
better to squash these patches.

Second, as already mentioned, we need to assign a SPDX ID for this.

Did you check with SPDX if there a matching ID?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
EMACS belongs in <sys/errno.h>: Editor too big!