[U-Boot] [PATCH v6 01/17] arm: ls102xa: Add Freescale LS102xA SoC support

[Wolfgang Denk]

Dear Alison Wang,

In message <1409895853-17736-2-git-send-email-alison.wang at freescale.com> you wrote:
> 
> +	unsigned long sysclk = CONFIG_SYS_CLK_FREQ;
> +
> +	sys_info->freq_systembus = sysclk;
> +#ifdef CONFIG_DDR_CLK_FREQ
> +	sys_info->freq_ddrbus = CONFIG_DDR_CLK_FREQ;
> +#else
> +	sys_info->freq_ddrbus = sysclk;
> +#endif

I think this should be simplified into a

	#ifndef CONFIG_DDR_CLK_FREQ
	#define CONFIG_DDR_CLK_FREQ	CONFIG_SYS_CLK_FREQ
	#endif

somewhere in a header file, and getting rid of the #ifdef here?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Drun'? 'm not drun'! You woudn' dare call m' drun' if I was sober!
                                     - Terry Pratchett, _Men at Arms_