[U-Boot] [PATCH] nand/denali: Adding Denali NAND driver support

[Chin Liang See]

Hi Masahiro,

On Fri, 2014-09-05 at 12:01 +0900, Masahiro Yamada wrote:
> Hi Chin,
> 
> Are you planning to send v10
> with the fixes suggested by Scott?
> 

I am out of office and I will look into the comments by mid of this
week. Thanks

Chin Liang

> 
> Best Regards
> Masahiro Yamada
> 
> 
> 
> On Tue, 2 Sep 2014 21:15:52 -0500
> Scott Wood <scottwood at freescale.com> wrote:
> 
> > On Sat, 2014-08-30 at 07:45 -0400, Tom Rini wrote:
> > > On Thu, Aug 28, 2014 at 11:13:40AM +0900, Masahiro Yamada wrote:
> > > > Hi Scott,
> > > > 
> > > > 
> > > > On Tue, 19 Aug 2014 04:47:40 -0500
> > > > Chin Liang See <clsee at altera.com> wrote:
> > > > 
> > > > > To add the Denali NAND driver support into U-Boot.
> > > > > This driver is leveraged from Linux.
> > > > > 
> > > > > Signed-off-by: Chin Liang See <clsee at altera.com>
> > > > > Cc: Scott Wood <scottwood at freescale.com>
> > > > > Cc: Masahiro Yamada <yamada.m at jp.panasonic.com>
> > > > > ---
> > > > > Changes for v9
> > > > > - Updated the commit messageb
> > > > > - Removed macro kern_xx
> > > > > - Removed debug macro
> > > > > - Changed CONFIG_NAND_DENALI_64BIT to CONFIG_SYS_NAND_DENALI_64BIT
> > > > 
> > > > 
> > > > Any comments?
> > > > 
> > > > If nothing, please apply this patch.
> > > 
> > > I don't see anything obviously wrong here, but since Scott has reviewed
> > > previous versions I want to give him a little more time to ack.  I'm OK
> > > pulling this into master with Scott's ack or lets say Wednesday next
> > > week and we'll ask Chin Liang to address any late feedback.  Thanks all!
> > 
> > I still don't see a reference to the SHA of the corresponding Linux
> > driver.
> > 
> > #define MODE5_WORKAROUND 0 still exists even though it's never used.
> > 
> > I still see (void *) casts in memcpy -- v8 comments said "removed" but
> > not all instances were removed.
> > 
> > It still introduces CONFIG_SYS_NAND_DENALI_64BIT without documenting it.
> > 
> > -scott
> > 
> 
> 
>