[U-Boot] [RFCv2] mainline u-boot on socfpga

Michal Simek monstr at monstr.eu
Mon Sep 8 14:35:26 CEST 2014


Hi Pavel,

On 09/08/2014 02:08 PM, Pavel Machek wrote:
> Hi!
> 
> I know coding style leaves something to be desired.

It is more than this. Also SPDX license headers, etc.

> But.. it recognizes MMC/ethernet, and can load linux kernel.
> 
> Unfortunately, 1MB of memory at 0 is not available for some reason;
> but linux works ok if you avoid that area.
> 
> "fpga load 0" now seems to work.
> 
> For some reason, I had to rewrite fpgamgr_axi_write(). There's some
> bug in assembly version, causing code to get confused after it is
> executed.
> 
> If some ARM expert could take a look, that would be great; bug is
> likely also present in rocketboards version of u-boot.
> 

I have quickly looked at this patch and there are a lot of things in one patch
and it is not possible to even quickly review. Please create patches
with proper description and then we can review.

For drivers/fpga/altera.c please look at xilinx wrappers and change altera
code based on that. Hopefully you can add all fpga code to drivers/fpga.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140908/5be79fcb/attachment.pgp>


More information about the U-Boot mailing list