[U-Boot] [PATCH] imx: ventana: Avoid undefined behaviour

Stefano Babic sbabic at denx.de
Tue Sep 9 16:27:44 CEST 2014


On 22/08/2014 09:46, Thierry Reding wrote:
> From: Thierry Reding <treding at nvidia.com>
> 
> The leds array within struct ventana has space for 3 elements, but the
> setup_board_gpio() function tries to set up 4 GPIOs for LEDs. Recent
> versions of GCC complain about that:
> 
> 	board/gateworks/gw_ventana/gw_ventana.c: In function 'setup_board_gpio':
> 	board/gateworks/gw_ventana/gw_ventana.c:987:27: warning: iteration 3u invokes undefined behavior [-Waggressive-loop-optimizations]
> 	   if (gpio_cfg[board].leds[i])
> 				   ^
> 	board/gateworks/gw_ventana/gw_ventana.c:986:2: note: containing loop
> 	  for (i = 0; i < 4; i++) {
> 	  ^
> 
> Fix this by making the upper bound of the loop match the array size.
> 
> Signed-off-by: Thierry Reding <treding at nvidia.com>
> ---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic



-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list