[U-Boot] [PATCH] arch/arm: Add individual TLB size support.

Li.Xiubo at freescale.com Li.Xiubo at freescale.com
Wed Sep 10 05:10:27 CEST 2014


Hi Albert,

> Subject: Re: [PATCH] arch/arm: Add individual TLB size support.
> 
> Hi Xiubo,
> 
> On Mon, 7 Jul 2014 13:19:11 +0800, Xiubo Li <Li.Xiubo at freescale.com>
> wrote:
> 
> > This adds CONFIG_TLB_SIZE for individual board, whose TLB size maybe
> > larger than PGTABLE_SIZE.
> >
> > Signed-off-by: Xiubo Li <Li.Xiubo at freescale.com>
> > ---
> >  arch/arm/lib/board.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> > index dc34190..b7327ce 100644
> > --- a/arch/arm/lib/board.c
> > +++ b/arch/arm/lib/board.c
> > @@ -353,7 +353,11 @@ void board_init_f(ulong bootflag)
> >
> >  #if !(defined(CONFIG_SYS_ICACHE_OFF) && defined(CONFIG_SYS_DCACHE_OFF))
> >  	/* reserve TLB table */
> > +#ifdef CONFIG_TLB_SIZE
> > +	gd->arch.tlb_size = CONFIG_TLB_SIZE;
> > +#else
> >  	gd->arch.tlb_size = PGTABLE_SIZE;
> > +#endif
> >  	addr -= gd->arch.tlb_size;
> >
> >  	/* round down to next 64 kB limit */
> 
> There is no code in current mainline which defines CONFIG_TLB_SIZE;
> that makes the patch a dead code addition.
>

Yes, this will be used by our LS1 SoC first, and it is still doing
The upstream.

 
> Besides, what's the point of this as opposed to, e.g., just defining the
> right PGTABLE_SIZE, or renaming PGTABLE_SIZE as CONFIG_TLB_SIZE?
> 

We'll add the LPAE support in uboot and need more space for tlb.

Thanks very much,

BRs
Xiubo





More information about the U-Boot mailing list