[U-Boot] [PATCH 09/10] kconfig: move CONFIG_OF_* to Kconfig

[Jaehoon Chung]

Hi,

On 09/09/2014 12:44 PM, Akshay Saraswat wrote:
> Hi Masahiro,
> 
>> Hi  Samsung developers,
>> Simon Glass,
>>
>>
>> 2014-09-09 1:10 GMT+09:00 Masahiro YAMADA :
>>> Hi Stephen,
>>>
>>>
>>> 2014-09-09 0:58 GMT+09:00 Stephen Warren :
>>>> On 09/08/2014 09:57 AM, Masahiro YAMADA wrote:
>>>>>
>>>>> Hi Stephen,
>>>>>
>>>>>
>>>>>
>>>>> 2014-09-09 0:04 GMT+09:00 Stephen Warren :
>>>>>
>>>>>> I don't believe this is the correct approach; CONFIG_OF_CONTROL isn't a
>>>>>> user-configurable option, and hence shouldn't show up in *_defconfig.
>>>>>> "select OF_CONTROL" in a Kconfig file probably makes sense though.
>>>>>
>>>>>
>>>>>
>>>>> I think it depends on the board (SoC).
>>>>>
>>>>> In my understanding,  Zynq boards should work with/without Device Tree
>>>>> control.
>>>>> (Moreover, Zynq boards work with/without  SPL)
>>>>>
>>>>> At least as for Zynq,
>>>>> CONFIG_OF_CONTROL  ( and CONFIG_SPL too) is a user-configurable option.
>>>>>
>>>>> (Michal, please correct me if I am wrong.)
>>>>>
>>>>>
>>>>> I am not familiar with Tegra SoCs, but
>>>>> do Tegra boards always Device Tree? ( and only work with SPL ?)
>>>>>
>>>>> If so,
>>>>>
>>>>> config TEGRA
>>>>>          select SPL
>>>>>          select OF_CONTROL
>>>>>
>>>>> looks better?
>>>>
>>>>
>>>> That looks correct for Tegra.
>>>>
>>>
>>> OK.  I will send v2.
>>> CONFIG_OF_CONTROL in tegra defconfigs will go away.
>>>
>>>
>>> (BTW, I forgot to mention a famous board; beaglebone black.
>>>
>>> am335_boneblack_defconfig disables CONFIG_OF_CONTROL,
>>> whereas am335_boneblack_vboot_defconfig enables it. )
>>>
>>
>> Before posting v2 of this series,
>> please let me ask the same question on Exynos and Sandbox
>>
>>
>> Do Exynos boards always need Device Tree to run U-Boot?
>> (that is,  CONFIG_OF_CONTROL must be "select"ed.)
>>
> 
> Yes, all Exynos5 boards need Device Tree to run U-Boot.
> In case of Snow and Pit, we use U-Boot's DTB to extract corresponding Kernel DTB.
> Also, we do check (#ifdef) CONFIG_OF_CONTROL to enable some features and IPs.
> I am not sure about Exynos4 but I can see CONFIG_OF_LIBFDT in their config files.

I knew Exynos4/5 are supported the Device-tree,
but older Samsung SoCs isn't supported it. 

Best Regards,
Jaehoon Chung

> 
>> or
>>
>> Do they work with/without Device Tree?
>> (that is, users can enable/disable via "make menuconfig" or friends.)
>>
>>
>> What about Sandbox?
>>
>>
>>
>>
>> Best Regards
>> Masahiro Yamada
> 
> Regards,
> Akshay Saraswat
>