[U-Boot] [PATCH] odroid: set MPLL clock to 880MHz

[Lukasz Majewski]

Hi Jaehoon,

> Hi,
> 
> On 09/11/2014 02:03 PM, Minkyu Kang wrote:
> > On 05/09/14 19:50, Przemyslaw Marczak wrote:
> >> Hello Minkyu,
> >>
> >> On 09/05/2014 08:55 AM, Minkyu Kang wrote:
> >>> On 24/07/14 19:42, Przemyslaw Marczak wrote:
> >>>> This patch changes MPLL from 800MHz to 880MHz on Odroid.
> >>>>
> >>>> Signed-off-by: Przemyslaw Marczak <p.marczak at samsung.com>
> >>>> ---
> >>>>   board/samsung/odroid/odroid.c | 60
> >>>> +++++++++++++++++++++---------------------- 1 file changed, 30
> >>>> insertions(+), 30 deletions(-)
> >>>>
> >>>
> >>> applied to u-boot-samsung.
> >>>
> >>> Thanks,
> >>> Minkyu Kang.
> >>>
> >>>
> >> Thank you for applying the Odroid patch set.
> >>
> >> I would like to note, that this one patch was intended for MR.
> >> Daniel just for his tests.
> >>
> >> This patch breaks dw mmc performance:
> >> e.g. eMMC uImage(fat) read performance:
> >> - before this commit: 47.6 MiB/s
> >> - after this commit: 13.0 MiB/s
> >> So this requires some more changes in clocks and also in dw mmc
> >> driver.
> 
> MPLL is used to the eMMC's source clock.
> If MPLL is changed to 880MHz, then eMMC's clock should not be set to
> correct value. It has to test before changed MPLL clock. otherwise,
> we need to use other source clock.

Yes, correct.

But for now this patch introduces considerable performance regression.

Moreover, as Przemek had written it down to Minkyu, this patch was
supposed solely for Daniel's private usage and shouldn't be applied to
u-boot main line.

Hence I'd like to ask for removing this patch from the pull request
sent to Albert.


> 
> Best Regards,
> Jaehoon Chung
> 
> >>
> >> And it can break some kernel clocks divider dependencies.
> >> It is not tested.
> >>
> >> So please revert this patch.
> >>
> >> Best Regards,
> > 
> > reverted..
> > 
> > Thanks,
> > Minkyu Kang.
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
> > 



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group