[U-Boot] [PATCH 1/2] SPI: mxc_spi: remove second reset from ECSPI config handler
Stefano Babic
sbabic at denx.de
Fri Sep 12 10:50:58 CEST 2014
Hi Markus,
On 01/09/2014 10:46, Markus Niebel wrote:
> From: Markus Niebel <Markus.Niebel at tq-group.com>
>
> the second reset prevents other registers to be written.
> This will prevent to have the correct signal levels for
> SCLK before writing to the config reg in spi_xchg_single.
>
> Tested with GPIO based chipselect and SPI_MODE_3 on i.MX6S
>
> Signed-off-by: Markus Niebel <Markus.Niebel at tq-group.com>
> ---
> drivers/spi/mxc_spi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c
> index 2d5f385..6a05d15 100644
> --- a/drivers/spi/mxc_spi.c
> +++ b/drivers/spi/mxc_spi.c
> @@ -163,9 +163,6 @@ static s32 spi_cfg_mxc(struct mxc_spi_slave *mxcs, unsigned int cs,
> reg_ctrl = (reg_ctrl & ~MXC_CSPICTRL_POSTDIV(0x0F)) |
> MXC_CSPICTRL_POSTDIV(post_div);
>
> - /* We need to disable SPI before changing registers */
> - reg_ctrl &= ~MXC_CSPICTRL_EN;
> -
> if (mode & SPI_CS_HIGH)
> ss_pol = 1;
>
>
Acked-by: Stefano Babic <sbabic at denx.de>
Jagannadha, this series is currently assigned to me in patchwork. Should
I merge into u-boot-imx or do you prefer to merge the two patches into
u-boot-spi ?
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
More information about the U-Boot
mailing list