[U-Boot] [PATCH 05/35] mmc: dw_mmc: cleanups

Marek Vasut marex at denx.de
Mon Sep 15 19:25:24 CEST 2014


On Monday, September 15, 2014 at 06:00:47 PM, Dinh Nguyen wrote:
> On 09/15/2014 06:05 AM, Marek Vasut wrote:
> > From: Pavel Machek <pavel at denx.de>
> > 
> > The dw_mmc driver was responding to errors with debug(). Change that
> > to prinf()/puts() respectively so that any errors are immediately
> > obvious. Also adjust english in comments.

[...]

> > @@ -290,7 +292,7 @@ static void dwmci_set_ios(struct mmc *mmc)
> > 
> >  	struct dwmci_host *host = (struct dwmci_host *)mmc->priv;
> >  	u32 ctype, regs;
> > 
> > -	debug("Buswidth = %d, clock: %d\n",mmc->bus_width, mmc->clock);
> > +	debug("Buswidth = %d, clock: %d\n", mmc->bus_width, mmc->clock);
> 
> Did you intend to use printf here also? Or just fix up the spacing
> around mmc->bus_width?

This cannot be a printf(), since you would get an output upon every call of 
.set_ios(). This would generate a wall of text. So this is formatting fix.

Best regards,
Marek Vasut


More information about the U-Boot mailing list