[U-Boot] [PATCH v2 1/3] compiler_gcc: prevent redefining attributes

Masahiro Yamada yamada.m at jp.panasonic.com
Fri Sep 19 04:36:08 CEST 2014


On Thu, 18 Sep 2014 20:10:27 +0200
Jeroen Hofstee <jeroen at myspectrum.nl> wrote:

> The libc headers on FreeBSD and likely related projects as well contain an
> header file, cdefs.h which provides similiar functionality as linux/compiler.h.
> It provides compiler independent defines like __weak __packed, to allow
> compiling with multiple compilers which might have a different syntax for such
> extension.
> 
> Since that header file is included in multiple standard headers, like stddef.h
> and stdarg.h, multiple definitions of those defines will be present if both are
> included. When compiling u-boot the compiler will warn about it hundreds of
> times since e.g. common.h will include both files indirectly.
> 
> commit 7ea50d52849fe8ffa5b5b74c979b60b1045d6fc9 "compiler_gcc: do not redefine
> __gnu_attributes" prevented such redefinitions, but this was undone by commit
> fb8ffd7cfc68b3dc44e182356a207d784cb30b34 "compiler*.h: sync
> include/linux/compiler*.h with Linux 3.16".
> 
> Add the checks back where necessary to prevent such warnings.
> 
> As the original patch this checkpatch warning is ignored:
> "WARNING: Adding new packed members is to be done with care"
> 
> Cc: Masahiro Yamada <yamada.m at jp.panasonic.com>
> Cc: Tom Rini <trini at ti.com>
> Signed-off-by: Jeroen Hofstee <jeroen at myspectrum.nl>


Acked-by: Masahiro Yamada <yamada.m at jp.panasonic.com>



More information about the U-Boot mailing list