[U-Boot] [PATCH 31/51] fpga: altera: Make altera_validate return normal values

Pavel Machek pavel at denx.de
Mon Sep 22 11:16:04 CEST 2014


On Sun 2014-09-21 15:12:12, Marek Vasut wrote:
> Make the function return either 0 or -EINVAL, that is, normal
> expected error codes and success codes instead of true/false
> nonsense.
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Chin Liang See <clsee at altera.com>
> Cc: Dinh Nguyen <dinguyen at altera.com>
> Cc: Albert Aribaud <albert.u.boot at aribaud.net>
> Cc: Tom Rini <trini at ti.com>
> Cc: Wolfgang Denk <wd at denx.de>

Acked-by: Pavel Machek <pavel at denx.de>

> @@ -133,7 +133,7 @@ int altera_info(Altera_desc *desc)
>  {
>  	int ret_val = FPGA_FAIL;
>  
> -	if (!altera_validate (desc, (char *)__func__)) {
> +	if (altera_validate (desc, (char *)__func__)) {
+       if (altera_validate(desc, (char *)__func__)) {

You have extra space there, checkpatch would be angry.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


More information about the U-Boot mailing list