[U-Boot] [PATCH] i2c: mxs: Add I2C multibus support

Otavio Salvador otavio at ossystems.com.br
Tue Sep 23 15:49:27 CEST 2014


On Tue, Sep 23, 2014 at 8:48 AM, Heiko Schocher <hs at denx.de> wrote:
> Hello Marek,
>
> Am 23.09.2014 13:15, schrieb Marek Vasut:
>>
>> The i.MX28 has two I2C IP blocks, but the MXS I2C driver is hard-coded
>> to use the I2C block 0 . Add multibus support so we can use both I2C
>> busses as seen fit.
>>
>> Signed-off-by: Marek Vasut<marex at denx.de>
>> Cc: Stefano Babic<sbabic at denx.de>
>> ---
>>   drivers/i2c/mxs_i2c.c | 47
>> +++++++++++++++++++++++++++++++++++++----------
>>   include/configs/mxs.h |  1 +
>>   2 files changed, 38 insertions(+), 10 deletions(-)
>
>
> Sorry, I have to NACK this patch. Please convert the driver for using
> the CONFIG_SYS_I2C framework, see for example the drivers/i2c/mxc_i2c.c
> driver, thanks!

I think the conversion could be a follow up patch, I see no good
reason to block this patch as is.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


More information about the U-Boot mailing list