[U-Boot] [PATCH 2/3] arm: socfpga: config: Enable USB support

[Marek Vasut]

On Wednesday, September 24, 2014 at 12:21:04 AM, Dinh Nguyen wrote:
> On Tue, Sep 23, 2014 at 2:55 PM, Dinh Nguyen
> 
> <dinguyen at opensource.altera.com> wrote:
> > On Sun, 21 Sep 2014, Marek Vasut wrote:
> >> Enable support for the DWC2 USB controller.
> >> 
> >> Signed-off-by: Marek Vasut <marex at denx.de>
> >> Cc: Chin Liang See <clsee at altera.com>
> >> Cc: Dinh Nguyen <dinguyen at altera.com>
> >> Cc: Albert Aribaud <albert.u.boot at aribaud.net>
> >> Cc: Tom Rini <trini at ti.com>
> >> Cc: Wolfgang Denk <wd at denx.de>
> >> Cc: Pavel Machek <pavel at denx.de>
> >> ---
> >> 
> >>  include/configs/socfpga_cyclone5_common.h | 8 ++++++++
> >>  1 file changed, 8 insertions(+)
> >> 
> >> diff --git a/include/configs/socfpga_cyclone5_common.h
> >> b/include/configs/socfpga_cyclone5_common.h index 49504dc..3f8f91f
> >> 100644
> >> --- a/include/configs/socfpga_cyclone5_common.h
> >> +++ b/include/configs/socfpga_cyclone5_common.h
> >> @@ -157,6 +157,14 @@
> >> 
> >>  #define CONFIG_BAUDRATE                      115200
> >>  
> >>  /*
> >> 
> >> + * USB
> >> + */
> >> +#ifdef CONFIG_CMD_USB
> >> +#define CONFIG_USB_DWC2
> >> +#define CONFIG_USB_STORAGE
> > 
> > Don't you also need:
> > 
> > #define CONFIG_USB_DWC2_REG_ADDR 0xffb40000
> > 
> > for the base address for the USB1 on SOCFPGA?
> 
> Now that I saw patch 50/51 "arm: socfpga: Split SoCFPGA configuration",
> I think these defines should go into socfpga_cyclone5.h

Yeah, the board specific goes into socfpga_cyclone5.h , since that's de-facto 
support for the SoCDK board. The "generic" part goes into 
socfpga_cyclone5_common.h .

Best regards,
Marek Vasut