[U-Boot] [PATCH 50/51] arm: socfpga: Split SoCFPGA configuration

[Pavel Machek]

Hi!

> > From: Pavel Machek <pavel at denx.de>
> > 
> > Split the SoCFPGA configuration into SoC-specific part which is
> > common for all boards (socfpga_cyclone5_common.h) and a board
> > specific part. There is currently only one board, which is the
> > generic SoCFPGA board (socfpga_cyclone5.h), but there are more
> > to come.
> > 
> > This is necessary due to various features of the boards, which
> > unfortunatelly cannot be autodetected.
> > 
> > Signed-off-by: Marek Vasut <marex at denx.de>
> > Cc: Chin Liang See <clsee at altera.com>
> > Cc: Dinh Nguyen <dinguyen at altera.com>
> > Cc: Albert Aribaud <albert.u.boot at aribaud.net>
> > Cc: Tom Rini <trini at ti.com>
> > Cc: Wolfgang Denk <wd at denx.de>
> > Cc: Pavel Machek <pavel at denx.de>
> > ---
> >  include/configs/socfpga_cyclone5.h        | 211 ++----------------------------
> >  include/configs/socfpga_cyclone5_common.h | 196 +++++++++++++++++++++++++++
> >  2 files changed, 207 insertions(+), 200 deletions(-)
> >  create mode 100644 include/configs/socfpga_cyclone5_common.h
> 
> Thanks for taking a stab at this, but I think it makes more sense to have
> socfpga_commoh.h and socfpga_cyclone5.h. The _common file can have most of
> the common settings for u-boot, while _cyclone5 will have the base addresses
> for all the various IP blocks. Then once everything is done for Cyclone5, we
> can add support for the Arria5 SOC by just adding socfpga_arria5.h.

socfpga_common.h sounds like a good name.

But I wonder if socfpga_cyclone5.h should be named
socfpga_cyclone5_socdk.h ?

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html