[U-Boot] [PATCH 2/4] dm: do not check the existence of uclass operation

Simon Glass sjg at chromium.org
Sun Sep 28 17:15:15 CEST 2014


On 28 September 2014 07:52, Masahiro Yamada <yamada.m at jp.panasonic.com> wrote:
> The function uclass_add() checks uc_drv->ops as follows:
>
>         if (uc_drv->ops) {
>                 dm_warn("No ops for uclass id %d\n", id);
>                 return -EINVAL;
>         }
>
> It seems odd because it warns "No ops" when uc_drv->ops has
> non-NULL pointer.  (Looks opposite.)
>
> Anyway, most of UCLASS_DRIVER entries have no .ops member.
> This check makes no sense.
>
> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>

Acked-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list