[U-Boot] [PATCH] ci_udc: force full-speed operation if !CONFIG_USB_GADGET_DUALSPEED

Marek Vasut marex at denx.de
Sun Sep 28 22:28:03 CEST 2014


On Sunday, September 28, 2014 at 09:12:35 PM, Eric Nelson wrote:
> Signed-off-by: Eric Nelson <eric.nelson at boundarydevices.com>
> ---
>  drivers/usb/gadget/ci_udc.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c
> index 2572b34..9f2fd15 100644
> --- a/drivers/usb/gadget/ci_udc.c
> +++ b/drivers/usb/gadget/ci_udc.c
> @@ -777,6 +777,11 @@ static int ci_pullup(struct usb_gadget *gadget, int
> is_on) /* select DEVICE mode */
>  		writel(USBMODE_DEVICE, &udc->usbmode);
> 
> +#if !defined(CONFIG_USB_GADGET_DUALSPEED) && defined(CONFIG_MX6)
> +		/* force full-speed mode */
> +		writel(readl(&udc->portsc)|(1<<24), &udc->portsc);
> +#endif
> +

setbits_le32() and I'm sure you know better than to use 1 << 24 . Please define 
that bit proper. And you also know you should supply a commit message, right ?

>  		writel(0xffffffff, &udc->epflush);
> 
>  		/* Turn on the USB connection by enabling the pullup resistor */

Best regards,
Marek Vasut


More information about the U-Boot mailing list