[U-Boot] drivers/net/phy/icplus.c delete reason

Wolfgang Denk wd at denx.de
Tue Sep 30 10:25:59 CEST 2014


Dear Dmitry,

In message <542A5861.7010000 at tibbo.com> you wrote:
> 
> 4 Aug 2014 in this mailing list you requested deletion of ICPLUS driver 
> for a frequently used and cheap IP101A/G phy. Is there are better 
> alternative PHY driver in U-Boot for this device? If not, could you 
> patch it back?

The commit message is pretty explicit about the reason:

commit 368b4d2b49bbbf379d9334747fbbd2aaaafe4356
Author: Masahiro Yamada <yamada.m at jp.panasonic.com>
Date:   Mon Aug 4 08:11:37 2014 +0900

    drivers: net: remove dead drivers
    
    The following configs are not defined at all:
    
     - CONFIG_INCA_IP_SWITCH
     - CONFIG_PBL2800_ETHER
     - CONFIG_PHY_ICPLUS
    
    Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>

There is/was not a single board configuration in mainline U-Boot which
defined CONFIG_PHY_ICPLUS, i. e. the driver was just dead, unused
code.

So the PHY may be "frequently used and cheap", but the driver for it
has never been used in mainline, so we finally got rid of the dead
weight.

I can see no reason to adding it back - this can be easily done if
someone wants to actually use this driver, i. e. for example if you
submit a boad configuration which references it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"It's when they say 2 + 2 = 5 that I begin to argue."    - Eric Pepke


More information about the U-Boot mailing list