[U-Boot] [PATCH v1] dm: spi: Convert Freescale QSPI driver to driver model

Haikun.Wang at freescale.com Haikun.Wang at freescale.com
Wed Apr 1 04:35:45 CEST 2015


On 4/1/2015 10:26 AM, Simon Glass wrote:
> On 23 March 2015 at 17:26, Simon Glass <sjg at chromium.org> wrote:
>> On 17 March 2015 at 05:26, Haikun Wang <haikun.wang at freescale.com> wrote:
>>> Move the Freescale QSPI driver over to driver model.
>>>
>>> Signed-off-by: Haikun Wang <Haikun.Wang at freescale.com>
>>> Signed-off-by: Peng Fan <Peng.Fan at freescale.com>
>>> ---
>>>
>>> This patch adds DM support for FSL QSPI driver.
>>> Now this driver can support both DM frame and old SPI frame.
>>> Driver structure like below:
>>>
>>> QSPI driver common code
>>>
>>> #ifndef CONFIG_DM_SPI
>>> Old SPI frame interface
>>> #else
>>> DM SPI frame interface
>>> #endif
>>>
>>> changes in v1: None
>>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> But unfortunately this breaks mx6sxsabresd_spl among others:
>
> +../drivers/spi/fsl_qspi.c: In function ‘qspi_enable_ddr_mode’:
> +../drivers/spi/fsl_qspi.c:372:20: error: ‘priv’ undeclared (first use
> in this function)
> +../drivers/spi/fsl_qspi.c:372:20: note: each undeclared identifier is
> reported only once for each function it appears in
> +../drivers/spi/fsl_qspi.c: In function ‘qspi_init_ahb_read’:
> +../drivers/spi/fsl_qspi.c:406:15: error: ‘priv’ undeclared (first use
> in this function)
> +make[2]: *** [drivers/spi/fsl_qspi.o] Error 1
> +make[1]: *** [drivers/spi] Error 2
>
> Can you please respin?
>
> Regards,
> Simon
>
Yes, I will send a new version later.

-- 

Best regards,
Wang Haikun


More information about the U-Boot mailing list